Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH runner auto update #679

Merged
merged 11 commits into from
Jul 28, 2021
Merged

GH runner auto update #679

merged 11 commits into from
Jul 28, 2021

Conversation

DavidGOrtega
Copy link
Contributor

New GH runners restarts after update and we destroy them if they exit the CML wrapper. To avoid that we are always downloading latest.

@DavidGOrtega DavidGOrtega temporarily deployed to internal July 28, 2021 10:52 Inactive
@DavidGOrtega DavidGOrtega requested a review from casperdcl July 28, 2021 10:52
@DavidGOrtega DavidGOrtega temporarily deployed to internal July 28, 2021 10:56 Inactive
casperdcl
casperdcl reviewed Jul 28, 2021
View reviewed changes
src/drivers/github.js Show resolved Hide resolved
bin/cml-runner.js Outdated Show resolved Hide resolved
bin/cml-runner.js Outdated Show resolved Hide resolved
@DavidGOrtega @casperdcl
timeout: 72
e4823e4 
Co-authored-by: Casper da Costa-Luis <[email protected]>
@DavidGOrtega DavidGOrtega temporarily deployed to internal July 28, 2021 11:05 Inactive
@DavidGOrtega @casperdcl
timeout idleTimeout
b46e083 
Co-authored-by: Casper da Costa-Luis <[email protected]>
@DavidGOrtega DavidGOrtega temporarily deployed to internal July 28, 2021 11:06 Inactive
casperdcl
casperdcl reviewed Jul 28, 2021
View reviewed changes
bin/cml-runner.js Outdated Show resolved Hide resolved
@casperdcl casperdcl temporarily deployed to internal July 28, 2021 11:07 Inactive
@casperdcl casperdcl added bug Something isn't working enhancement New feature or request cml-image Subcommand labels Jul 28, 2021
@casperdcl casperdcl temporarily deployed to internal July 28, 2021 11:12 Inactive
@casperdcl casperdcl added the p0-critical Max priority (ASAP) label Jul 28, 2021
@casperdcl casperdcl merged commit 7cbc820 into master Jul 28, 2021
@casperdcl casperdcl deleted the dead-runner branch July 28, 2021 11:15
@casperdcl casperdcl linked an issue Jul 28, 2021 that may be closed by this pull request
GH runner version alignment to avoid delays #641
Closed
@casperdcl casperdcl mentioned this pull request Jul 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

Assignees

@DavidGOrtega DavidGOrtega

Labels
bug Something isn't working cml-image Subcommand enhancement New feature or request p0-critical Max priority (ASAP)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected stop of container build [CML, AWS, github] GH runner version alignment to avoid delays
2 participants
@DavidGOrtega @casperdcl